-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch/#159 default tag bug #160
Patch/#159 default tag bug #160
Conversation
This was outdated code from an earlier idea I had
FYI, I tried implementing the solution they gave in the answer to this open issue: It didn't work. It also broke a bunch of other tests so I'm going to steer away from it. |
This comment was marked as resolved.
This comment was marked as resolved.
Seem option 2 is better, prettier default using double quotes, Unless |
…alue It is being too troublesome to implement. It also isn't part of the official jsDoc spec. I think people would most likely either use values directly or use the JS doc official syntax so I don't see much reason in trying to support it.
I'm not trying to match against both square and curly boilerplates so I only need the one boiler plate type to match against
@hosseinmd can you take another look? I've resolved all feedback. I decided it wasn't worth trying to support The official jsDoc spec says that if there is going to be boilerplate wrapped around the value then it would be So with this PR I'm supporting both of these formats:
I'm not supporting UPDATE
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about [{}]
jsdoc documented this @default [<some value>]
but it doesn't mean to add type inside []
This comment was marked as resolved.
This comment was marked as resolved.
This reverts commit cc89717.
That was a misunderstanding. The documentation means that the value is optional. It doesn't want you to put litteral square brackets in your code.
The official documentation says that `@defaultvalue` should be all lowercase. Implementing support for this was more difficult than I expected. I'm droping this as being out of scope for this PR. I have no intention of using the all lowercase `@defaultvalue` tag so I don't care about trying to support it.
@hosseinmd ready for another review. I removed support for the I also attempted to implement support for |
This fixes issue #159