Avoid popping the view controller on refresh if the presentedViewController is nil #226
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When triggering a refresh on a view, the application incorrectly redirects back and refreshes the previous view in the navigation stack.
Assumption
If
navigationController.presentedViewControlleris not nil, a modal is assumed to be displayed, and the expected behavior is to pop the view controller and dismiss the modal.Resolution
Only pop the view controller when
presentedViewControlleris not nil. If presentedViewController is nil, avoid popping the view controller to prevent unintended navigation behavior.