Echoing out project name #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n converting many projects into a mono repo takes a long time)
|
Thanks for the PR :) I'm not sure how useful it is to have an extra debug printf right after the one two lines up. Maybe you could change that to include the project name? (additionally: cosmetic, but if possible please keep commit messages in git commit format. 50 lines summary, empty line, elaboration in 72 max width. this plays nice with GitHub and other tools. see https://chris.beams.io/posts/git-commit/ ) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Echoing out project name to help locate issues (especially useful when converting many projects into a mono repo takes a long time)