Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "directories" crate with "platform_dirs" #285

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Replace "directories" crate with "platform_dirs" #285

merged 1 commit into from
Oct 12, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 11, 2020

The directories create is no longer maintained.
Also it uses ~/Library/Preferences on MacOS (dirs-dev/directories-rs#62), but Apple advises against creating files in Preferences sufolder:

This directory contains app-specific preference files. You should not create files in this directory yourself. Instead, use the NSUserDefaults class or CFPreferences API to get and set preference values for your app.In iOS, the contents of this directory are backed up by iTunes and iCloud.

platform-dirs allows to use ~/.config on MacOS.

@marsam
Replace directories with platform_dirs create
1a14016 
`directories` create is no longer maintained, and uses
`~/Library/Preferences` on MacOS, but Apple advises against creating
files in `Preferences`.

`platform-dirs` allows to use `~/.config` on MacOS.
@hrkfdn
Copy link
Owner

hrkfdn commented Oct 12, 2020

Thanks, I guess with the CLI context switching over to XDG paths is reasonable for macOS. Merged!

@hrkfdn hrkfdn merged commit 6bb2c08 into hrkfdn:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marsam @hrkfdn