Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thrillville Off The Rails - vertex range culling breaks it #11781

Closed
hrydgard opened this issue Feb 9, 2019 · 1 comment · Fixed by #11785
Closed

Thrillville Off The Rails - vertex range culling breaks it #11781

hrydgard opened this issue Feb 9, 2019 · 1 comment · Fixed by #11785
Milestone
v1.8.0

Comments

@hrydgard
Copy link
Owner

hrydgard commented Feb 9, 2019 •
edited
Loading

Turns out that vertex range culling is killing every vertex in the game! What gives...

Here's a GE capture:

ULES00889_0001.zip
@hrydgard hrydgard added this to the v1.8.0 milestone Feb 9, 2019
@hrydgard hrydgard changed the title Thrillville Off The Rails has somehow broken again Thrillville Off The Rails - vertex range culling breaks it Feb 9, 2019
@unknownbrackets
Copy link
Collaborator

unknownbrackets commented Feb 10, 2019 •
edited
Loading

I've been slammed recently, but I'm pretty sure the viewport Z accounting is wrong in the depth range uniform calculation. I was testing a fix with some games but need to get back to it.

Checked quickly and this uses 0/65535 which I think means it is the same issue.

-[Unknown]

unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Feb 10, 2019
@unknownbrackets
GPU: Correct depth clamp range in range cull.
b955ec7 
It was just wrong before, causing wrong culling when using a non-standard
viewport scale/center for depth.

Fixes hrydgard#11701, fixes hrydgard#11781.
@unknownbrackets unknownbrackets mentioned this issue Feb 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging a pull request may close this issue.

GPU: Correct depth clamp range in range cull unknownbrackets/ppsspp
2 participants
@hrydgard @unknownbrackets