Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct vocp / vsocp prefix handling #11835

Merged
merged 4 commits into from
Feb 24, 2019

Conversation

unknownbrackets
Copy link
Collaborator

@unknownbrackets unknownbrackets commented Feb 23, 2019

I've become suspicious of vbfy's prefix handling, but haven't tested it yet. Indeed, vbfy does this too. This explains much weird prefix behavior.

Previously I had tested prefix handling on vscl, and it behaved strangely when used with t. Now it seems obvious that regnum swizzle was fixed, and probably explains why constants seemed to behave strange.

Also added vsbz/vlgb based on tests (they are pretty straight forward.) Didn't really test prefixes with them, though.

-[Unknown]

See hrydgard#5549.  Matches tests for various prefix settings.
Very similar to vsop, just with a bit more fixed values.
@unknownbrackets unknownbrackets added this to the v1.8.0 milestone Feb 23, 2019
Verified by tests.  Also, confirmed that the old vxbz encoding had no
output, but the new position (as used by gas) does.
Not sure any games actually use them, but good to have the remaining vfpu
ops all implemented.
@hrydgard
Copy link
Owner

Very nicely investigated! This makes a ton of sense, of course.

@hrydgard hrydgard merged commit f742b79 into hrydgard:master Feb 24, 2019
@unknownbrackets unknownbrackets deleted the vfpu-artdink branch February 24, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants