Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU: Assume a scissor of 481x273 is a mistake #12746

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

unknownbrackets
Copy link
Collaborator

We already do this for viewport, and only when region is still a correct size. Helps flicker in Everybody's Golf. I think it's relatively safe.

See comments in #12355 - this was causing flicker. It's possible this is related to #6655, because I think this flicker only occurs on the green.

This doesn't fix the Vulkan perf issue mentioned there, though.

-[Unknown]

We already do this for viewport, and only when region is still a correct
size.  Helps flicker in Everybody's Golf.
@unknownbrackets unknownbrackets added this to the v1.10.0 milestone Mar 22, 2020
@hrydgard hrydgard merged commit a70f00c into hrydgard:master Mar 22, 2020
@unknownbrackets unknownbrackets deleted the gpu-size-est branch March 22, 2020 13:57
unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this pull request May 21, 2020
Assume it's still wrong in this case and take 480x272.  See hrydgard#12746.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants