Only allow sceMpegGetAvcAu warmup for God Eater Series #14091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
reviewed
Feb 9, 2021
| @@ -79,6 +79,7 @@ void Compatibility::CheckSettings(IniFile &iniFile, const std::string &gameID) { | |||
| CheckSetting(iniFile, gameID, "ShaderColorBitmask", &flags_.ShaderColorBitmask); | |||
| CheckSetting(iniFile, gameID, "DisableFirstFrameReadback", &flags_.DisableFirstFrameReadback); | |||
| CheckSetting(iniFile, gameID, "DisableRangeCulling", &flags_.DisableRangeCulling); | |||
| CheckSetting(iniFile, gameID, "MpegWarmUpForGodEaterSeries", &flags_.MpegWarmUpForGodEaterSeries); | |||
There was a problem hiding this comment.
Let's just call this MpegWarmUp. We might find other uses.
There was a problem hiding this comment.
I will add warm up in sceMpegGetAtracAu for fix another games , change MpegWarmUpForGodEaterSeries to MpegWarmUp would confuse name.
There was a problem hiding this comment.
OK, for now. I hope eventually we can find a universal solution to these instead of relying on compat.ini hacks.
There was a problem hiding this comment.
I'm obviously not a fan of the idea of having an array of warm up flags for every HLE function. If we have to do this though, MpegAvcWarmUp would be a better name.
I think we need to figure out what the actual variables are that cause the delay, which btw is seen in most pspautotests of Mpeg even with firmware 1.50 set.
-[Unknown]
There was a problem hiding this comment.
@unknownbrackets My goal for sceMpegGetAtracAu 's warmup don't need add games in compat.ini
hrydgard
added a commit
that referenced
this pull request
Feb 9, 2021
Panderner
added a commit
to Panderner/ppsspp
that referenced
this pull request
Feb 14, 2021
* Adds two new tests to GPU driver test screen: Adreno shader logic test and flat shading The adreno test tests for the bug mentioned in hrydgard#13910. Very clear repro on Adreno 630, Pocophone F1. The flat shading test is an untested attempt at a repro of (will test that tomomorrow). * Add texture to flat shaded test. * Compat: Note that 3 LEGO games those are require Buffered rendering * More GPU test improvements * Fix the flat test. Unfortunately doesn't repro the bug :( * GL FB readback: Only use "inout" if we actually want to read from the fb. * Headless: Allow screenshot compare without backend. This makes not just graphics-enabled tests work in headless on softgpu, but also screenshot comparison ones. * Headless: Read expected file as a FileLoader. This makes it possible to run tests from network locations. * Headless: Allow PNGs and http:// for screenshot. * Headless: Disable http disk cache. * Headless: Simplify executing a ppdmp via headless. * Headless: Default to PNG for ppdmp tests. * GPU: Fix safe size checks when rect offscreen. * Vulkan: Prevent scaling shader leak. No need to recreate if they haven't changed. * Compat: Enable reinterpret for Kingdom Hearts. See hrydgard#11223. Should enable it for everything at some point. * Debugger: Add API to trigger buttons. * Debugger: Broadcast ctrl input events. This can be useful to trigger debugging functionality on button press. * Debugger: Include all press states for convenience. In case of a multi-button shortcut, which might be common for debugging. * Kernel: Adjust sceKernelGetThreadExitStatus timing. See hrydgard#13703. * PGF Fixed Bold & Italic property and camouflage the Font name. * Oops! I misstook uploading jpn0.pgf. * Resample all mp3 Fix hrydgard#5213 * Fix Russian (Cyrillic alphabet) on jpn0.pgf. * Some marks position fixed on jpn0.pgf * build fix * PPGe: Scale down by worst of window/internal res. See hrydgard#13958. * compat.ini: Add Split/Second to [ReinterpretFramebuffers]. See hrydgard#13957 * Plugins: Enable by default. * Resample only in 32000Hz * Fix Greek characters & Roman numbers & all balance on jpn0.pgf * Do PtpConnect internally during PtpOpen, since some games (ie. The Warriors) seems to do PtpSend immediately after PtpOpen without trying to PtpConnect first. * Fix returned error code on PtpSend and PtpRecv when socket is not connected yet. * OpenGL fragment shader gen: Fix precision inconsistency for v_color0/1. Probably won't fix anything, just want this in for, well, consistency. Noticed it debugging the iOS flat shading issues, but doesn't fix that. * Fix duplicate shader version in the flat shader test Unbreaks the flat shading test on Adreno (ended up in trying to link a #version 300 and a #version 320 shader together which it didn't like) * Io: Don't allow async close while async busy. See hrydgard#6582. * GE: Better naming of render passes for color reinterpret * GPU: Respect stencil write mask for 5551 buffers. If the mask is 0x7F on 5551, that's equivalent to allowing the clear entirely. See hrydgard#13391. * D3D9: Don't allow separate alpha clears. Doesn't seem like the color mask applies to clears. * Reporting: Expose CRC queue methods for other uses. This way UI can expose the CRC if needed. * Don't allow ForcedFirstConnect hack when using PtpConnect within PtpOpen to prevent returning result from blocking PtpConnect instead of result of PtpOpen. * sceMp3Init:Add layerBits and versionBits information * Add header information * GLES: Remove direct khrplatform.h header include. Shouldn't be needed anymore, was a hack for Nokia. See hrydgard#13978. * Mp3: Correct error handling for newer sdk versions. The 6.xx behavior might be important if a game relies on it to add data. * Mp3: Allow decode without pcm pointer. Just like other audio decoding, you're allowed to skip audio. Also prevents a crash if the mp3 is not yet inited. * Add back XCode TARGETED_DEVICE_FAMILY config line xcode warns that the value is deprecated or something, but maybe it still does something. Appears iPad support is broken right now. * Mp3: Always keep sample rate from original mp3. Our codec context is updated with the source sample rate, so this makes us not resample at all. Converting to stereo still seems correct. * Updated GameMode initial data sync, in case remote players aren't listening yet when sending initial data (fix Pocket Pool) * Mp3: Correct logging for init. * Remove duplicates from ThreadManForKernel * Vulkan: Add MMPX upscaling texture shader. See https://casual-effects.com/research/McGuire2021PixelArt/index.html * Vulkan: Allow tex shaders to specify a max scale. * Specify MaxScale=2 for the new MMPX texture scaling shader * Fix Greek characters ltn0~7.pgf * gitlab ci change requested by m4xw * FindFFmpeg: Fix a few issues 1. postproc now looks for postprocess.h (there is no postproc.h header). 2. pkg-config fallback condition now works (find_path/library set the variable to ${var}-NOTFOUND but it was checking for an empty string). * (.gitlab-ci.yml) Add windows-x64 target * Mpeg:Only allow firmware >= 3 for warmup Fix hrydgard#13996 * Try to build fix on non-windows * CMake: Add USE_UBSAN * CMake: Rename USE_ADDRESS_SANITIZER to USE_ASAN For consistency with USE_UBSAN * CMake: Fix UBSAN link error * Fix Russian characters ltn8~15.pgf * Fix alignment issues in ISOFileSystem Fixes hrydgard#14002 * jit: Make branch shift more obvious. And also not technically undefined behavior. * Fix connection issue on Dynasty Warriors (Shin Sangoku Musou) games when playing with more than 2 players. * Minimize the Adreno shader compiler bug repro test * Fix left shift of negative value in MIPSCodeUtils Fixes a benign UBSAN error to improve the signal-to-noise ratio of UBSAN errors. Fixes hrydgard#14015 * x64Emitter: Fix unaligned store UBSAN errors This compiles to the same assembly as before even without optimizations and avoids UB. https://godbolt.org/z/4G5edM While the UB here is benign, this improves signal-to-noise ratio of UBSAN errors. Fixes hrydgard#14005 * Fix logging flags 1. The logging flags were being ignored (-v, -d) 2. Adds a `--loglevel` argument. Useful when using the debug build for ASAN/UBSAN to hide extremely noisy debug messages. * Attempt to fix hrydgard#14022 * Fix Apple gpu detection * Core: Correct branch analysis truncation. * jit: Be very clear on sign extension. * Only force the log level if it set via an argv Follow-up to hrydgard#14019 * Io: Consistently use LE values of ISO entries. Better to be consistent across big endian and little endian, in case something was mastered wrong. * Vulkan: Fix image layout issues after compute shader uploads. We're already in GENERAL so probably not worth to transfer to DST just to do even more transfers due to the silliness of GenerateMip. I'm planning to rework the whole texture upload thing to be far more optimal with some kind of TextureUploadManager Fixes hrydgard#13987 * Mpeg:Only allow firmware >= 6 for warmup Fix blue screen in hrydgard#13146 * Ge: Improve some logging and memchecks. Explicitly trigger memchecks on readback. * Ge: Restore saved context when ending a list. Otherwise another list queued by a Head push could use the wrong context data. See hrydgard#13346. * Framedump test screen. Downloads a list of framedumps. * Add a new command in developer tools to list and load framedumps from framedump.ppsspp.org/repro/ Useful to make it easy to test GPU driver bugs etc, without having to use real games or copying files around. * Add checkbox to enable/disable driver bug workarounds. * Fix minor rendering glitch in PPSSPP's menus on iOS * Have the flat shading workaround obey the driver workarounds checkbox * Loaders: Prevent errors on 0 byte reads. Was happening when opening an http:// GE frame dump. * Core: Maintain frame dump disc ID in SFO. This way we won't generate a fake one later and use it for anything else. * vertexjit: Correct saved registers on x64. * Core: Assert debug stats remain positive. * vertexjit: Only save extra regs on x64. * Updated PdpStat and PtpStat * Update README.md for 1.11 * Address initial feedback by iota97 * List fixed games. Thanks sum2012 * More from unknown and sum2012 * More stuff in README.md * (.gitlab-ci.yml) Add linux-i686 and windows-i686 targets (+ prevent creation of 'null' file when building Windows libretro cores) * Fix possible lock issue during AdhocMatchingStart * Updated PdpStat to prevent rcv_sb_cc from exceeding the buffer size arg (since we use larger buffer size to prevent micro stutters or disconnection issue due to too many dropped packets with small buffer size). TODO: May need to improve it to be able to calculate the correct size if there are multiple datagram messages * UI: Correct developer tools test run. * Make a couple of UI animations refresh rate independent * Core: Reset state properly on CPU init failure. * Windows: Prevent crash on null symbol map. Happened during a double error scenario, but might as well check. * We don't really need to allocate a buffer when using MSG_TRUNC on recvfrom * Minor renaming * Moving hleDelayResult from internal function of SetSocketAlert to prevent waking up HLE-blocked thread * Fix possible race condition issue. * Fix jpn0.pgf characters position. * Debugger: Populate funcs if disassembly open early. * PPGe: Fallback to atlas text on alloc fail. * PPGe: Clear text allocations on shutdown. * Updated some Logs to help finding the location of the call to debug. * Removing hleDelayResult from internal adhoc functions to prevent waking up thread that supposed to be blocked by the outer HLE. * Run the link script * Run the link script, fixups * Update lang,pspautotests submodules * Do the title screen animation by accumulator instead, to avoid a long first frame breaking it. * Update version to 1.11 * PPGe: Decimate text images properly. * Add more games to ReportSmallMemStick * Handle exec addr errors better - don't let IgnoreBadMemoryAccesses skip dispatcher exceptions. It would then just fall through into the compiler and die. Should remove one of the "mystery" crashes from hrydgard#14082. * Cause the correct type of exception. Never ignore EXEC_ADDR exceptions. * Buildfix * GL: Call CreateDeviceObjects *after* updating render_. Also remove a redundant call to fetch render_ in the constructor, it's already passed in. * Remove now-redundant check * Only allow sceMpegGetAvcAu warmup for God Eater Series Fix hrydgard#14086 * Rename the new warmup variable from hrydgard#14091 * SaveState: Prevent crash on bad cookie marker. Just fail to load the save state. * Update lang submodule (it_IT updates) * Remove a completely unnecessary check in BackgroundAudio.cpp that caused glitching at 44.1khz. Fixes hrydgard#14096 * Assorted paranoid cleanups, inspired by hrydgard#14082 * Fix frozen (0 FPS) issue on Kao Challengers and Asterix & Obelix XX (probably also fix other games from the same developer with similar issue) hrydgard#14103 * Windows recvfrom doesn't support MSG_TRUNC, so we're using dummy buffer with max size as alternative for peeking actual size of the next pending message. * Update zh_CN and zh_TW * Fix lobby issue on The Warriors, probably also fix similar issue on other games too. * Update README.md for 1.11.1 * Slight simplification in LogoScreen Not that I think those crashes actually are from this... * Update version to 1.11.1 * Some GLSL compilers are very particular about the sign of shift operands.. * Revert (partially) "compat.ini: Add Split/Second to [ReinterpretFramebuffers]. See hrydgard#13957" Also see hrydgard#14123 . Not sure I intended to actually do this. This reverts commit d0c3a5a. * GPU: Force reinterpret off without copy image. Also, assert we have it when using it, since there's ifs. * Add some checks trying to prevent creation of 0 sized textures. Saw a crash log with a driver crash in CreateTexture... * Update lang submodule * Io: Truncate reads/writes to valid memory. A PSP might crash in these cases, but it's better if we avoid a crash. * Don't assert on invalid format in CwCheat. Not sure exactly what we should do, though.. * Build: Allow on actions test branch. * Build: Cache Qt during Actions run. * Android: Ensure shutdown waits for render. We apparently have a case where render is busy during shutdown, based on crash reports. Co-authored-by: Henrik Rydgård <[email protected]> Co-authored-by: Unknown W. Brackets <[email protected]> Co-authored-by: nassau-tk <[email protected]> Co-authored-by: sum2012 <[email protected]> Co-authored-by: ANR2ME <[email protected]> Co-authored-by: AdamN <[email protected]> Co-authored-by: Florin9doi <[email protected]> Co-authored-by: Gleb Mazovetskiy <[email protected]> Co-authored-by: jdgleaver <[email protected]> Co-authored-by: Anuskuss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14086
This is the worse thing that I find this fix God Eater.