Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Pro Yakyu Spirits 2010 (NPJH50234): Rendering errors with hardware transform off #14167

Closed
nassau-tk opened this issue Feb 17, 2021 · 10 comments · Fixed by #14231
Closed
Labels
GE emulation Backend-independent GPU issues
Milestone

Comments

@nassau-tk
Copy link
Contributor

nassau-tk commented Feb 17, 2021

What happens?

Some Graphics are not appear correctly only Android. (EDIT: Turned out to be with hw transform off)
But, This issue will happen only Android.
(OpenGL & Vulkan both.)
Windows10 is not happen.

GEdump here(Got from Android).
But, If you open the file on Windows then it will seems correctly.
NPJH50234_0004.zip

So, Please see attache screenshot.

[Windows10 appear the Left & Right Team symbols correctly.]
image

[Android is missing the Left & Right Team symbols.]
Screenshot_20210217-115050_PPSSPP

This BaseBall game has a other series.

Plus,Other series(2011~2014) has another graphic glitch. #13980 😁

What should happen?

Appear the graphic correctly.

What hardware, operating system, and PPSSPP version? On desktop and mobile phone, GPU matters for graphical issues.

Please test newest version in https://buildbot.orphis.net/ppsspp/

I tested Windows & Android.

[No Problem]
PPSSPP Ver.:1.11.2-85
OS:Windows10(64-bit)Japanese
CPU:Ryzen7 3800X(8-core)
GPU:RADEON RADEON RX5700XT
Resolution:2560×1440
RAM:32GB

[Have a Problem]
PPSSPP Ver.:1.11.2-85
OS:Android 11.0
DeviceName:Samusung Galaxy S20 / SC-51A
CPU:Snapdragon865(Octa-core)
GPU:Adreno 650
Resolution:3200 x 1440 (Max)
RAM:12GB
ROM:128GB
ExternalStrage:microSDXC 512GB

@Panderner
Copy link
Contributor

Panderner commented Feb 17, 2021

Have you tried OpenGL and Vulkan for your PC?
It seems it doesn't occur for D3D9 and D3D11

@nassau-tk
Copy link
Contributor Author

Hey! @Panderner 👍 ✨

I said ==> "This issue happen only Android". 😆
So, Any backend has no problem on Windows PC.

@Panderner
Copy link
Contributor

Panderner commented Feb 17, 2021

Hmm this GE Dump looks right for my Realme C2 and POCO M3 too.
Screenshot_2021-02-17-15-55-14-10_2f85358b2198d26f8aca533d68bee793

@nassau-tk
Copy link
Contributor Author

@Panderner

Ooooops!!!
Sorry and Thanks!!
My Phone was turning off on "Hardware Transform"!

Close!!

@hrydgard
Copy link
Owner

Although that's still a bug! we want both on and off to work the same. I'm reopening, it's probably worth fixing.

@hrydgard hrydgard reopened this Feb 17, 2021
@hrydgard hrydgard added this to the v1.12.0 milestone Feb 17, 2021
@hrydgard hrydgard changed the title [Android] Pro Yakyu Spirits 2010 (NPJH50234): Some Graphics are not appear correctly only Android. [Android] Pro Yakyu Spirits 2010 (NPJH50234): Rendering errors with hardware transform off Feb 17, 2021
@nassau-tk
Copy link
Contributor Author

Really? 😮 wao...

@Panderner
Copy link
Contributor

If you turn off hardware transform the team symbols disappears.

Hardware transform on:
Screenshot_2021-02-17-17-48-15-677_org ppsspp ppsspp

Hardware transform off:
Screenshot_2021-02-17-17-48-21-929_org ppsspp ppsspp

@Panderner
Copy link
Contributor

@nassau-tk have you tried to turn off hardware transform for your PC?

@nassau-tk
Copy link
Contributor Author

@Panderner

Yes, I did it.
Result is same yours.

@sum2012 sum2012 added the GE emulation Backend-independent GPU issues label Feb 21, 2021
unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Feb 28, 2021
@unknownbrackets
Copy link
Collaborator

If I disable light 0, it works, so it's definitely related to that. Software rendering is fine, only software transform effected. Disabling alpha blend/test makes it fully black, so it's turning to zero.

The issue here is that normal * world ends up as a zero vector, and normalize(vec3(0)) ends up as NaN. It seems like glsl is handling this better, but I could imagine different drivers / implementations handling differently.

It seems clear from this case that the PSP considers normalize(vec3(0)) to equal vec3(0, 0, 1) or similar, and we've seen this before elsewhere.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants