Emulating HW vrnd #17506
Merged
Emulating HW vrnd #17506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
requested changes
May 25, 2023
There was a problem hiding this comment.
This is great! Really only have a couple of code style tweaks to suggest, and a savestate compatibility fix.
I suppose you could also file an issue to https:/jpcsp/jpcsp/issues and tell them that you've cracked it :)
|
Fixed, I think. |
hrydgard
approved these changes
May 25, 2023
|
Are you working in the future btw? :)
Think you've got your timezone set wrong. |
See investigation starting hrydgard#16946 (comment) for more details. Still needs more testing.
fp64
added a commit
to fp64/ppsspp
that referenced
this pull request
Jun 5, 2023
Followup to hrydgard#17506.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vrnd stuff from #16946 (see #16946 (comment) onwards).
Still needs more testing, just putting it there to get overall comments.
Only tested in couple of games (including Ridge Racer, which is known to use vrnd). Seems to work fine, with no visual differences.
Bumps save state version for
MIPSState, so save states are probably incompatible.