Loader: Support HI16/16 pairs, not just LO16 #17602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motorstorm: Arctic Edge US uses these pairs for some VFPU loads. Without relocating these, strange shadows show underneath vehicles. It appears as if actual firmware pairs with any non-HI16 relocation.
|
Oh wow, talk about a non-obvious cause of a graphical issue! Great find! Could you link to the report on report.ppsspp.org in this PR description? |
|
Looking at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17561 tripped in Motorstorm: Arctic Edge, but initially making sure pairs matched didn't make any obvious impact.
https://report.ppsspp.org/logs/kind/1185
After some testing and comparing with PSP relocation behavior (mostly via RAM dumps), it seems that R_MIPS_16 (and maybe any other type) is paired with the R_MIPS_HI16 relocation for the purposes of the carry.
After matching that behavior, the shadows in the game appear to be fixed. Fixes #7552.
-[Unknown]