Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable anisotropic filtering for replacement textures with mipmaps #17930

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

hrydgard
Copy link
Owner

This should fix the issue seen in #17891 where if the game itself doesn't use mipmaps, but the replacement texture does, anisotropic filtering wasn't enabled.

Although I think we could be more generous about enabling anisotropic filtering - possibly we should just always turn it on, if enabled, instead of only using it together with mipmapping. It does help with the look of filtering textures at steep angles even if they don't have mipmaps by reducing shimmer. That change though I'll do after the release.

@hrydgard hrydgard added GE emulation Backend-independent GPU issues Texture replacement labels Aug 18, 2023
@hrydgard hrydgard added this to the v1.16.0 milestone Aug 18, 2023
@hrydgard hrydgard merged commit fce95be into master Aug 18, 2023
15 checks passed
@hrydgard hrydgard deleted the replacement-fix-aniso branch August 18, 2023 13:23
@unknownbrackets
Copy link
Collaborator

I thought we used to always use it when enabled, as long as it wasn't nearest. I guess that changed?

-[Unknown]

@hrydgard
Copy link
Owner Author

I think we didn't want to apply it in slope/fixed level modes, to be safe from games doing weird tricks with miplevels. But might be too conservative and led to more complicated logic which led to this, I guess.

Not 100% sure this is the right sequence of events though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues Texture replacement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants