GPS: updates #18669
Merged
GPS: updates #18669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Florin9doi
commented
Jan 6, 2024
•
Florin9doi
commented
- Simulate fresh updates to satisfy MAPLUS 1/2 when real GPS data isn't available
- Remove NmeaListener workaround for Android 29 SDK
- Add constants for GPGGA tokens
|
MAPLUS apps also need GPS location from within Japan, but this is likely expected. |
Florin9doi
changed the title
hrydgard
reviewed
Jan 10, 2024
Comment on lines
-78
to
-80
| // Use reflection to work around a bug in the Android 29 SDK. | ||
| // https://stackoverflow.com/questions/57975969/accessing-nmea-on-android-api-level-24-when-compiled-for-target-api-level-29 | ||
| try { |
There was a problem hiding this comment.
Hm, how come we can remove this?
There was a problem hiding this comment.
Oh wait, never mind, apparently it was indeed just the SDK that was buggy, not Android. it's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.