Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Fix trying to compare uninitialized parts of packed descriptors #18678

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

hrydgard
Copy link
Owner

Found by Valgrind.

Other minor cleanup, too.

This shouldn't have caused anything worse than slightly worse re-use of descriptors, fortunately.

@hrydgard hrydgard added this to the v1.17.0 milestone Jan 10, 2024
@hrydgard hrydgard marked this pull request as ready for review January 10, 2024 11:12
@hrydgard
Copy link
Owner Author

Hm, just realized that this might go badly in 32-bit builds. Will fix

@hrydgard hrydgard merged commit 67be881 into master Jan 10, 2024
18 checks passed
@hrydgard hrydgard deleted the fix-descriptor-compare branch January 10, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant