UI: Implement a glowing border touch control style #11435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It barely glows, though.
|
Nice, I'm gonna check what this looks like and probably merge later. |
|
Yeah as you say the glow is pretty small and mostly invisible when touching the buttons on an actual touchscreen. But seems fine to me, some people may prefer it. Maybe I'll later add a version with a larger glow - but I won't do it using glow effects, just a larger semitransparent blob underneath. |
|
It is cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorta like #5624, but not really the same because it barely glows. Just brighter and with a background. Didn't want to implement complicated bloom or color effects...
I kinda prefer this though, as I like it not covering up even more than my fingers already cover. When they double in size, sometimes I slip off them because I don't realize where their edges are, too.
-[Unknown]