Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to Ember 2.18+ #343

Merged
merged 6 commits into from
Dec 9, 2021
Merged

Update CI to Ember 2.18+ #343

merged 6 commits into from
Dec 9, 2021

Commits on Dec 9, 2021

  1. Update CI to Ember 2.18+

    @mixonic
    mixonic committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    e6b39cc View commit details
    Browse the repository at this point in the history

  2. link-to fixes

    @mixonic
    mixonic committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    d612726 View commit details
    Browse the repository at this point in the history

  3. Disable Ember modules polyfill on 3.27+ (#337) 

    When compiling with `compileModules: false`, ember-cli-babel defaults to
using the modules polyfill, since it assumes we are concatenating the
output script using `app.import` without an AMD wrapper.

This does not apply to us, since we are compiling the `-private` modules
into a single AMD module (via rollup below), which can in fact have
external dependencies.

We can opt-out of this with `disableEmberModulesAPIPolyfill: true`. In
Ember versions with "real modules", that is what we want in order to
avoid the Ember global deprecation (or just completely not working in
4.0+).

It seems like the intent may have been that we should be able to set
this to `true` unconditionally, and `ember-cli-babel` will ignore this
setting if the Ember verion requires the modules API polyfill. However,
presumably due to a bug, ember-cli-babel actually checks for this value
first and return out of the function early if its value is truthy. This
means that if we set this to true unconditionally, then we would have
disabled the modules polyfill for Ember versions that needs it, which
would be incorrect. Therefore, we have to duplicate the detection logic
here in order to set this value appropriately.

Ideally, we should just stop trying to rollup the -private modules and
let the modern build pipeline optimizes things for us, then none of this
would have been necessary.
    @chancancode @mixonic
    chancancode authored and mixonic committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    2668901 View commit details
    Browse the repository at this point in the history

  4. Drop template lint, not compatible with Ember 4

    @mixonic
    mixonic committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    cc7d8f1 View commit details
    Browse the repository at this point in the history

  5. Bump RAF to ^0.3.0

    @mixonic
    mixonic committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    fdee19d View commit details
    Browse the repository at this point in the history

  6. Upgrade the test suite

    @mixonic
    mixonic committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    f7792e0 View commit details
    Browse the repository at this point in the history