Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build with gcc-11 and clang-14 #981

Closed
wants to merge 0 commits into from
Closed

build with gcc-11 and clang-14 #981

wants to merge 0 commits into from

Conversation

pheiduck
Copy link

@pheiduck pheiduck commented Apr 22, 2022 •
edited
Loading

update ubuntu to 22.04 and clang to 14

@BenBE BenBE added the build system 🔧 Affects the build system rather then the user experience label Apr 22, 2022
BenBE
BenBE reviewed Apr 22, 2022
View reviewed changes
Copy link
Member

@BenBE BenBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any new static analyzer improvements / findings this triggers?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@pheiduck pheiduck changed the title build with clang-14 build with clang-14 merge ready in May Apr 22, 2022
@BenBE
Copy link
Member

BenBE commented Apr 22, 2022

I know this is somewhat nitpicking here, but could you please update your two commits, so the first one doesn't touch the ubuntu CI image selector? Commits should be specific to one thing they fix and leave other aspects untouched. TIA.

@pheiduck pheiduck changed the title build with clang-14 merge ready in May build with clang-14 Apr 23, 2022
@BenBE
Copy link
Member

BenBE commented May 6, 2022

Public Beta for Ubuntu 22.04 images started:
actions/runner-images#5490

@pheiduck : The cleanup for the patch series is still pending.

@pheiduck
Copy link
Author

@BenBE this can be merged now.

@BenBE
Copy link
Member

BenBE commented May 10, 2022

@BenBE this can be merged now.

Please combine/squash the various commits as mentioned/remarked upon earlier.

Furthermore, please check the spelling in the commit messages, as I think, there are some typos in there.

TIA.

@pheiduck
Copy link
Author

@BenBE done.

@BenBE
Copy link
Member

BenBE commented May 10, 2022

Hm, looks like most of the Ubuntu build tasks are still carried out on Ubuntu 20.04 LTS (focal) instead of Ubuntu 22.04 LTS (Jammy).

@pheiduck
Copy link
Author

Hm, looks like most of the Ubuntu build tasks are still carried out on Ubuntu 20.04 LTS (focal) instead of Ubuntu 22.04 LTS (Jammy).

I can apply this to the other build jobs as well.

@BenBE
Copy link
Member

BenBE commented May 10, 2022

This seems to break things:
https:/htop-dev/htop/actions/runs/2302402324

@pheiduck
Copy link
Author

pheiduck commented May 10, 2022 •
edited
Loading

This seems to break things: https:/htop-dev/htop/actions/runs/2302402324

I thought
i will revert it back and set latest tag for all

@pheiduck pheiduck changed the title build with clang-14 build with gcc-11 and clang-14 May 12, 2022
@pheiduck pheiduck closed this May 12, 2022
@pheiduck pheiduck deleted the build/clang14 branch May 12, 2022 06:57
@pheiduck pheiduck restored the build/clang14 branch May 12, 2022 07:00
@pheiduck pheiduck reopened this May 12, 2022
@pheiduck
Copy link
Author

@BenBE I added gcc-11 as well, what do you think?

@pheiduck pheiduck requested a review from BenBE May 12, 2022 08:28
@pheiduck pheiduck closed this May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenBE BenBE Awaiting requested review from BenBE

Assignees
No one assigned
Labels
build system 🔧 Affects the build system rather then the user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pheiduck @BenBE