Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to otel4s 0.5.0 #65

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

NthPortal
Copy link
Contributor

No description provided.

This was referenced Apr 2, 2024
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mid-review and missed the test failure, but it looks good if CI passes.

@NthPortal
Copy link
Contributor Author

@rossabaker the test failure was me trying to use an extractor in a for comprehension in scala 3

@NthPortal NthPortal merged commit 9dd8176 into http4s:main Apr 3, 2024
19 checks passed
@NthPortal NthPortal deleted the otel4s-0.5.0-update/PR branch April 3, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants