FIX: Change check if past_key_values is empty #2106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After transformers merged this PR:
huggingface/transformers#33703
The bool of
past_key_values
(aCache
instance) would change fromFalse
toTrue
in one of our checks:peft/src/peft/peft_model.py
Line 1779 in ccc3501
Use
get_seq_length()
method instead, which is consistent before and after that commit.I checked the tests with the new change for both transformers before and after that commit and they passed, so this change should be backwards compatible.