Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deepspeed] add many more models to the model zoo test #12695

Merged
merged 31 commits into from
May 10, 2022

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Jul 14, 2021

This PR continues figuring out how to make various models work with Deepspeed (a lot of fixes happen on the Deepspeed side), most models just work out of the box - the main purpose of this PR is to test as many models as possible. so there are no fixes to add.

  • update coverage to albert, bart, bert, bigbird_pegasus, big_bird, blenderbot, deberta, deberta_v2, distilbert, electra, flaubert, fsmt, funnel, gpt2, gptj, gpt_neo, layoutlm, led, longformer, marian, mbart, mobilebert, mpnet, pegasus, prophetnet, roberta, squeezebert, t5, t5_v1, vit, xlm_roberta, xlnet

Thanks to @LysandreJik for creating the tiny test models for many of HF models!

Some models I couldn't cover for a variety of reasons unrelated to Deepspeed (missing tokenizers, missing tiny models, missing example scripts to exercise these). But their status is documented in the script. Over time more will be tested.

Blocking events - all resolved:

@huggingface huggingface deleted a comment from github-actions bot Aug 28, 2021
@stas00 stas00 added DeepSpeed WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress labels Aug 28, 2021
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 5, 2022

The documentation is not available anymore as the PR was closed or merged.

@stas00 stas00 marked this pull request as ready for review May 9, 2022 23:36
@stas00 stas00 requested a review from sgugger May 9, 2022 23:36
@stas00 stas00 changed the title [WIP] [Deepspeed] model zoo continued [Deepspeed] model zoo continued May 9, 2022
@stas00 stas00 changed the title [Deepspeed] model zoo continued [Deepspeed] add many more models to the model zoo test May 9, 2022
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, thanks a lot @stas00 !

@stas00 stas00 merged commit f861504 into huggingface:main May 10, 2022
@stas00 stas00 deleted the ds-model-zoo-2 branch May 10, 2022 15:22
@sameeravithana
Copy link

nice work @stas00, have you tested Perceiver with DeepSpeed.

@stas00
Copy link
Contributor Author

stas00 commented May 10, 2022

Would be glad to do that, @sameeravithana- in order to do that I need is a Trainer-based example script that I can test with.

As you can see from this map:

tasks = dict(
trans=f"""
{scripts_dir}/translation/run_translation.py
--train_file {data_dir_wmt}/train.json
--source_lang en
--target_lang ro
""",
sum=f"""
{scripts_dir}/summarization/run_summarization.py
--train_file {data_dir_xsum}/sample.json
--max_source_length 12
--max_target_length 12
--lang en
""",
clm=f"""
{scripts_dir}/language-modeling/run_clm.py
--train_file {FIXTURE_DIRECTORY}/sample_text.txt
--block_size 8
""",
mlm=f"""
{scripts_dir}/language-modeling/run_mlm.py
--train_file {FIXTURE_DIRECTORY}/sample_text.txt
""",
qa=f"""
{scripts_dir}/question-answering/run_qa.py
--train_file {data_dir_samples}/SQUAD/sample.json
""",
clas=f"""
{scripts_dir}/text-classification/run_glue.py
--train_file {data_dir_samples}/MRPC/train.csv
--max_seq_length 12
--task_name MRPC
""",
img_clas=f"""
{scripts_dir}/image-classification/run_image_classification.py
--dataset_name hf-internal-testing/cats_vs_dogs_sample
--remove_unused_columns False
--max_steps 10
--feature_extractor_name {DS_TESTS_DIRECTORY}/vit_feature_extractor.json
""",

I have each model tested by one of HF Trainer examples. Is there one that can be used with perceiver?

Narsil pushed a commit to Narsil/transformers that referenced this pull request May 12, 2022
…2695)

* model zoo take 2

* add deberta

* new param for zero2

* doc update

* doc update

* add layoutlm

* bump deepspeed

* add deberta-v2, funnel, longformer

* new models

* style

* add t5_v1

* update TAPAS status

* reorg problematic models

* move doc to another PR

* style

* fix checkpoint check test

* making progress on more models running

* cleanup

* new version

* cleanup
ArthurZucker pushed a commit to ArthurZucker/transformers that referenced this pull request May 12, 2022
…2695)

* model zoo take 2

* add deberta

* new param for zero2

* doc update

* doc update

* add layoutlm

* bump deepspeed

* add deberta-v2, funnel, longformer

* new models

* style

* add t5_v1

* update TAPAS status

* reorg problematic models

* move doc to another PR

* style

* fix checkpoint check test

* making progress on more models running

* cleanup

* new version

* cleanup
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
…2695)

* model zoo take 2

* add deberta

* new param for zero2

* doc update

* doc update

* add layoutlm

* bump deepspeed

* add deberta-v2, funnel, longformer

* new models

* style

* add t5_v1

* update TAPAS status

* reorg problematic models

* move doc to another PR

* style

* fix checkpoint check test

* making progress on more models running

* cleanup

* new version

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeepSpeed WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants