Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Support image on README.md #16615

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Conversation

BritneyMuller
Copy link
Contributor

What does this PR do?

Updates the Support image linking to our Expert Acceleration Program Page.

The Marketing + Monetization Team felt this image deserved a refresh to better highlight the incredible Machine Learning Experts at Hugging Face. In addition, we hope this helps drive additional EAP awareness among our brilliant community members in an effort to better support their ML work/roadmaps.

Updates the Support image linking to our EAP page (to give it a refresh + help avoid image fatigue).

Slack thread checking in with #open-source-internal on this update (https://huggingface.slack.com/archives/C021H1P1HKR/p1648838903316709)
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 5, 2022

The documentation is not available anymore as the PR was closed or merged.

@julien-c
Copy link
Member

julien-c commented Apr 5, 2022

whenever possible you should compress images using https://tinypng.com/

Here you'd be saving 83% for instance:

compressed image:
new-support (1)

Other than that, looks good to me! cc'ing @gary149 in case he has feedback on the design

Copy link
Contributor Author

@BritneyMuller BritneyMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compressed EAP/Support image via tinypng

@gary149
Copy link
Contributor

gary149 commented Apr 6, 2022

Other than that, looks good to me! cc'ing @gary149 in case he has feedback on the design

Looks ok to me, but the logo is distorted and maybe the image should be vertically smaller to take less space on the readme?

@BritneyMuller
Copy link
Contributor Author

BritneyMuller commented Apr 6, 2022

The logo shouldn't be distorted. Have tested this and the original image was verified/improved by our graphic designer, Bibi. @feconroses if you have any other thoughts?

@gary149 could you share additional details/screenshots to help us address any distortions?

@feconroses
Copy link

Looks good to me!

@julien-c
Copy link
Member

julien-c commented Apr 6, 2022

i think what @gary149 means is the logo is not the usual aspect ratio, it's "flatter". (let me invite Bibi to GitHub BTW)

@Bibi-O
Copy link

Bibi-O commented Apr 7, 2022

Hi! Bibi here. I'll have a look at the issue and resolve it

Updated the image based on logo + size feedback. Big thanks to Bibi for making quick edits to this image.
Copy link
Contributor Author

@BritneyMuller BritneyMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new-support-improved

Let us know if this looks okay now @gary149 @julien-c? Thanks for all your help on this @Bibi-O

@gary149
Copy link
Contributor

gary149 commented Apr 7, 2022

Ok for me.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you @BritneyMuller!

@LysandreJik LysandreJik merged commit 3e26e78 into main Apr 7, 2022
@LysandreJik LysandreJik deleted the BritneyMuller-new-support-image branch April 7, 2022 19:06
@julien-c
Copy link
Member

julien-c commented Apr 8, 2022

you should tweet about it @BritneyMuller!

@BritneyMuller BritneyMuller mentioned this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants