Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doctests] Correct task summary #16644

Merged
merged 1 commit into from
Apr 11, 2022
Merged

[Doctests] Correct task summary #16644

merged 1 commit into from
Apr 11, 2022

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Apr 7, 2022 •
edited
Loading

What does this PR do?

This PR rounds the results of the image classification pipeline to make it easier to test.
Fixing task_summary.mdx doc test

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 7, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

stevhliu
stevhliu approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ydshieh ydshieh mentioned this pull request Apr 8, 2022
Merged
@patrickvonplaten patrickvonplaten merged commit 098b002 into huggingface:main Apr 11, 2022
@patrickvonplaten patrickvonplaten deleted the correct_task_summary branch April 11, 2022 12:59
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@patrickvonplaten @elusenji
[Doctests] Correct task summary (huggingface#16644)
5f596e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@NielsRogge NielsRogge NielsRogge approved these changes

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrickvonplaten @HuggingFaceDocBuilderDev @sgugger @NielsRogge @stevhliu