Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate: min length can't be larger than max length #16668

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

gante
Copy link
Member

@gante gante commented Apr 8, 2022

What does this PR do?

Adds a simple check, as described in the PR title.

Closes #16622

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 8, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@gante gante merged commit b0bf301 into huggingface:main Apr 11, 2022
@gante gante deleted the generate_min_len_check branch April 11, 2022 10:55
@patrickvonplaten patrickvonplaten mentioned this pull request Apr 12, 2022
5 tasks
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
* min length must be smaller than max length

* Update min_length in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BART can only generate a maximum of 20 tokens
3 participants