Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate index.mdx (to ES) and add Spanish models to quicktour.mdx examples #16685

Merged
merged 11 commits into from
May 12, 2022
Merged

Translate index.mdx (to ES) and add Spanish models to quicktour.mdx examples #16685

merged 11 commits into from
May 12, 2022

Conversation

omarespejel
Copy link
Contributor

@omarespejel omarespejel commented Apr 9, 2022

What does this PR do?

Related to issue #15947

  1. Translate index.mdx to Spanish
  2. Replace English models and a dataset in quicktour.mdx with Spanish versions.

Relevant

  • Translation of index.mdx included the list of compatible models (not the papers´ and models´ names). Since this should not be updated manually, I can come back to the original text if required.
  • Spanish models selected for quicktour are:
    • clasificador = pipeline('sentiment-analysis', model="pysentimiento/robertuito-sentiment-analysis")
    • reconocedor_de_voz = pipeline("automatic-speech-recognition", model="jonatasgrosman/wav2vec2-large-xlsr-53-spanish", device=0)
  • Spanish ASR dataset selected is:
    • dataset = datasets.load_dataset("PolyAI/minds14", name="es-ES", split="train")

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

- Add tasks names in English too.
- Fix small nits in Spanish
* Translate body of index.
* Translated the compatible models list (not the papers´ names). Since this should not be updated manually, I can come back to the original text.
* Replaced the English models to Spanish versions.
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 9, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all of those! Just make sure to run make style on your branch to fix the quality issue.

@omarespejel
Copy link
Contributor Author

@sgugger, I ran make style and made some manual debug but cannot get check_code_quality to pass. Any idea why could it be?

I think the error is in these lines:

`
A continuación, carga el dataset (ve 🤗 Datasets Quick Start para más detalles) sobre el que quisieras iterar. Por ejemplo, vamos a cargar el dataset MInDS-14:

>>> from datasets import load_dataset, Audio

>>> dataset = load_dataset("PolyAI/minds14", name="es-ES", split="train")  # doctest: +IGNORE_RESULT

`

@sgugger
Copy link
Collaborator

sgugger commented May 4, 2022

Make sure you have the latest version of hf-doc-builder installed (pip install hf-doc-builder -U) then run make style.

@omarespejel omarespejel merged commit 1a66a6c into huggingface:main May 12, 2022
@omarespejel omarespejel deleted the es-docs branch May 12, 2022 04:35
@omarespejel omarespejel restored the es-docs branch May 12, 2022 04:35
@omarespejel omarespejel deleted the es-docs branch May 12, 2022 04:35
@omarespejel omarespejel restored the es-docs branch May 12, 2022 04:35
omarespejel added a commit that referenced this pull request May 12, 2022
@omarespejel
Copy link
Contributor Author

omarespejel commented May 12, 2022

EDIT: Fixed by @osanseviero in PR #17197.

Sorry @sgugger, even with updating hf-doc-builder to the latest version, 0.4.0, and running make style the check_code_quality error continues appearing. I am not able to find the error and the feedback in CircleCI is not revealing (ValueError: 1 files should be restyled!).

When running make style I get this error (I tried to debug in other ways but the error continues):
Screen Shot 2022-05-11 at 23 45 35

In the meantime, I merged the PR with the error so we can get the index and quicktour before the release tomorrow. However, please let me know if we should proceed in another way. Sorry for this cumbersome merge. They are looking fine in the docs:

@omarespejel omarespejel deleted the es-docs branch May 12, 2022 06:41
Narsil pushed a commit to Narsil/transformers that referenced this pull request May 12, 2022
…xamples (huggingface#16685)

* Change nits in Spanish for quicktour.mdx

- Add tasks names in English too.
- Fix small nits in Spanish

* Translate index.mdx to Spanish

* Translate body of index.
* Translated the compatible models list (not the papers´ names). Since this should not be updated manually, I can come back to the original text.

* Add models and a  dataset for Spanish in the code exmaples

* Replaced the English models to Spanish versions.

* Add index to _toctree.yml and fix Spanish

* Fix double ““ error

* Change negative example in ASR example

* make style

* Debug style in quicktour.mdx
ArthurZucker pushed a commit to ArthurZucker/transformers that referenced this pull request May 12, 2022
…xamples (huggingface#16685)

* Change nits in Spanish for quicktour.mdx

- Add tasks names in English too.
- Fix small nits in Spanish

* Translate index.mdx to Spanish

* Translate body of index.
* Translated the compatible models list (not the papers´ names). Since this should not be updated manually, I can come back to the original text.

* Add models and a  dataset for Spanish in the code exmaples

* Replaced the English models to Spanish versions.

* Add index to _toctree.yml and fix Spanish

* Fix double ““ error

* Change negative example in ASR example

* make style

* Debug style in quicktour.mdx
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
…xamples (huggingface#16685)

* Change nits in Spanish for quicktour.mdx

- Add tasks names in English too.
- Fix small nits in Spanish

* Translate index.mdx to Spanish

* Translate body of index.
* Translated the compatible models list (not the papers´ names). Since this should not be updated manually, I can come back to the original text.

* Add models and a  dataset for Spanish in the code exmaples

* Replaced the English models to Spanish versions.

* Add index to _toctree.yml and fix Spanish

* Fix double ““ error

* Change negative example in ASR example

* make style

* Debug style in quicktour.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants