Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed crash when deleting older checkpoint and files with name f"{checkpoint_prefix}-*" exist #16686

Merged
merged 1 commit into from
Apr 11, 2022
Merged

fixed crash when deleting older checkpoint and files with name f"{checkpoint_prefix}-*" exist #16686

merged 1 commit into from
Apr 11, 2022

Commits on Apr 10, 2022

  1. fixed crash when deleting older checkpoint and a file f"{checkpoint_p… 

    …refix}-*" exist

I create an archive of older checkpoints during training the checkpoint has a  name with `f"{checkpoint_prefix}-*.zip/.tar ` 
previously `glob(f"{checkpoint_prefix}-*")` takes all files/folders starting with the name checkpoint, and later `shutil.rmtree(checkpoint)` takes a folder name; since at some point it my get a zip file; it crashes training; adding this `if os.path.isdir(x)` allows only folders on `glob_checkpoints`
    @sadransh
    sadransh authored Apr 10, 2022
    Configuration menu
    Copy the full SHA
    bce7ef2 View commit details
    Browse the repository at this point in the history