Don't push checkpoints to hub in no_trainer scripts
#16703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerzr
changed the title
no_trainer scripts
muellerzr
added
PyTorch
sgugger
reviewed
Apr 11, 2022
Comment on lines
262
to
263
| if not os.path.exists(gitignore_path): | ||
| open(gitignore_path, "a").close() # Creates a .gitignore |
There was a problem hiding this comment.
I'd directly put here the step-* key.
There was a problem hiding this comment.
Ah, yeah that would be a bit more simplistic. Thanks!
There was a problem hiding this comment.
Simplified it to:
with open(os.path.join(args.output_dir, ".gitignore"), 'w+') as gitignore:
if "step_*" not in gitignore:
gitignore.write("step_*\n")
if "epoch_*" not in gitignore:
gitignore.write("epoch_*\n")Since we can have both epoch_ and step_
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't push checkpoints to the Hub in
no_trainerscriptsWhat does this add?
gitignorefile in the base folder ifpush_to_hubwas passed and one does not existsave_state, ifpush_to_hubwas passed then then directory is added to the .gitignoreWhy is it needed?
Users shouldn't expect to have all of their checkpoints sent to both the Hub and saved locally, it should just be locally until they are ready for the final save