Change the chunk_iter function to handle #16730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the subtle cases where the last chunk gets ignored since all the data is in the `left_strided` data. We need to remove the right striding on the previous item.
|
Very nice - thanks for fixing it! |
patrickvonplaten
approved these changes
Apr 12, 2022
|
@sgugger - I think the build doc failing test is unrelated here no? |
5 tasks
|
Yes, will look into that. |
patrickvonplaten
approved these changes
Apr 12, 2022
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* Change the chunk_iter function to handle the subtle cases where the last chunk gets ignored since all the data is in the `left_strided` data. We need to remove the right striding on the previous item. * Remove commented line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the subtle cases where the last chunk gets ignored since all the
data is in the
left_strideddata.We need to remove the right striding on the previous item.
What does this PR do?
Change the chunk_iter function to handle
the subtle cases where the last chunk gets ignored since all the
data is in the
left_strideddata.We need to remove the right striding on the previous item.
Fixes #16671
@LysandreJik @patrickvonplaten
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.