Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix savedir for by epoch in translation example #16996

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

muellerzr
Copy link
Contributor

What does this PR do?

Fixes up the no_trainer translation example to properly save the by_epoch to the right directory (before it saved to step, causing a slow test failure)

@muellerzr muellerzr added the Examples Which is related to examples in general label Apr 28, 2022
@muellerzr muellerzr requested a review from sgugger April 28, 2022 17:39
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming this fixes the slow test, thanks a lot!

@muellerzr muellerzr merged commit 3486a92 into main Apr 28, 2022
@muellerzr muellerzr deleted the muellerzr-fix-notrainer branch April 28, 2022 17:49
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 28, 2022

The documentation is not available anymore as the PR was closed or merged.

elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Examples Which is related to examples in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants