Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change about ARCHIVE_LIST for TF Data2Vec #17085

Merged
merged 1 commit into from
May 4, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented May 4, 2022

What does this PR do?

Just not to declare DATA2VEC_VISION_PRETRAINED_MODEL_ARCHIVE_LIST in TF test file.
But I don't mean to introduce it in the model (it was there already in that PR).

As we discussed before, it's better to just drop this variable, and use the checkpoint name directly in test_model_from_pretrained. I can change to that, just let me know :-)

@ydshieh ydshieh changed the title Change about ARCHIVE_LIST for TF Data2Vec Minor change about ARCHIVE_LIST for TF Data2Vec May 4, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 4, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh requested a review from sgugger May 4, 2022 14:20
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for now for consistency between models.

@ydshieh ydshieh merged commit 6dc4c36 into huggingface:main May 4, 2022
@ydshieh ydshieh deleted the minor_change_tf_data2vec_test branch May 4, 2022 16:39
nandwalritik pushed a commit to nandwalritik/transformers that referenced this pull request May 10, 2022
Narsil pushed a commit to Narsil/transformers that referenced this pull request May 12, 2022
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants