Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogSumExp trick question_answering pipeline. #17143

Merged
merged 2 commits into from
May 10, 2022

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented May 9, 2022

What does this PR do?

Fix #17140

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil Narsil requested a review from sgugger May 9, 2022 14:53
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 9, 2022

The documentation is not available anymore as the PR was closed or merged.

@Narsil Narsil merged commit 6d80c92 into huggingface:main May 10, 2022
Narsil added a commit to Narsil/transformers that referenced this pull request May 12, 2022
* LogSumExp trick `question_answering` pipeline.

* Adding a failing test.
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
* LogSumExp trick `question_answering` pipeline.

* Adding a failing test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow when normalizing start and end logits in QA pipeline
3 participants