Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the output of code examples in the preprocessing chapter #17162

Merged
merged 1 commit into from
May 10, 2022
Merged

Fixing the output of code examples in the preprocessing chapter #17162

merged 1 commit into from
May 10, 2022

Conversation

HallerPatrick
Copy link
Contributor

What does this PR do?

Fixes #17161 (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sgugger

@sgugger sgugger requested a review from stevhliu May 10, 2022 15:23
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 10, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR!
LGTM, but but let's wait for @stevhliu to have a look before merging.

stevhliu
stevhliu approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this error, looks good to me :)

@sgugger sgugger merged commit 259eeb6 into huggingface:main May 10, 2022
Narsil pushed a commit to Narsil/transformers that referenced this pull request May 12, 2022
@HallerPatrick @Narsil
Fixing the output of code examples in the preprocessing chapter (hugg…
8ef86f0 
…ingface#17162)
ArthurZucker pushed a commit to ArthurZucker/transformers that referenced this pull request May 12, 2022
@HallerPatrick @ArthurZucker
Fixing the output of code examples in the preprocessing chapter (hugg…
b08145b 
…ingface#17162)
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@HallerPatrick @elusenji
Fixing the output of code examples in the preprocessing chapter (hugg…
71dcbbf 
…ingface#17162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent output of code example in Proprocessing Chapter in Docu
4 participants
@HallerPatrick @HuggingFaceDocBuilderDev @sgugger @stevhliu