Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bart configuration update #19524

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Bart configuration update #19524

merged 3 commits into from
Oct 12, 2022

Conversation

imarekkus
Copy link
Contributor

Update to bart config.
image

Tests passed
image

@imarekkus
Copy link
Contributor Author

Hey @ydshieh! It turned out that copy-pasting the "(with random weights)" text was causing the check_code_quality test failure. But unfortunately I don't know what is causing this ConnectionResetError: [Errno 104] while building PR Documentation

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 12, 2022

Hey @ydshieh! It turned out that copy-pasting the "(with random weights)" text was causing the check_code_quality test failure.
Glad it works now 💯 Thank you!

But unfortunately I don't know what is causing this ConnectionResetError: [Errno 104] while building PR Documentation
You can ignore this :-)

@@ -101,3 +101,4 @@ src/transformers/models/wavlm/modeling_wavlm.py
src/transformers/models/whisper/modeling_whisper.py
src/transformers/models/whisper/modeling_tf_whisper.py
src/transformers/models/yolos/modeling_yolos.py
src/transformers/models/bart/configuration_bart.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put this line in a sorted order within this file 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

Putting this line in a sorted order
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 12, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, and thank you again @imarekkus 🔥 !

@ydshieh ydshieh merged commit 3ccda6d into huggingface:main Oct 12, 2022
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 18, 2022
* Update configuration_bart.py

* Update documentation_tests.txt

* Update documentation_tests.txt

Putting this line in a sorted order
kashif pushed a commit to kashif/transformers that referenced this pull request Oct 21, 2022
* Update configuration_bart.py

* Update documentation_tests.txt

* Update documentation_tests.txt

Putting this line in a sorted order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants