Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing mobile bert configuration doctest #19557

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

RamitPahwa
Copy link
Contributor

@RamitPahwa RamitPahwa commented Oct 13, 2022

What does this PR do?

Add configuration_mobilebert.py to utils/documentation_tests.txt for doctest.

Based on issue #19487

@sgugger / @ydshieh

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 13, 2022

The documentation is not available anymore as the PR was closed or merged.

@daspartho
Copy link
Contributor

@RamitPahwa There is an extra empty line in configuration_mobilebert.py that causes the tests to fail.
It would work nicely once you remove it =)

@RamitPahwa
Copy link
Contributor Author

@daspartho Thank for the help, should work now !

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @RamitPahwa !

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 13, 2022

And thanks @daspartho for the help 💯

@ydshieh ydshieh merged commit 1d4d9dc into huggingface:main Oct 13, 2022
kashif pushed a commit to kashif/transformers that referenced this pull request Oct 21, 2022
* Fixing mobile bert configuration doctest

* Fixed build failures by removing empty line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants