Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marian docstring #19634

Closed
wants to merge 11 commits into from
Closed

Marian docstring #19634

wants to merge 11 commits into from

Conversation

traveler-pinkie
Copy link

What does this PR do?

related to #16292

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ydshieh, @patrickvonplaten
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@traveler-pinkie
Copy link
Author

traveler-pinkie commented Oct 15, 2022

I need some help. This is my first time contributing to a project ever. I'm getting familiar with the process of git, and I've tried to follow the instructions layed out on the [Community Event] Doc Tests Sprint #16292. I ran the doc test locally and received to errors. But upon further inspection, I can't seem to find what the issue is. Please if you can offer come guidance on what I'm doing wrong and how to progress. I'm working on modeling_tf_marian.py

@traveler-pinkie
Copy link
Author

Screenshot 2022-10-13 223655

@traveler-pinkie traveler-pinkie deleted the marian-docstring branch October 16, 2022 04:53
@ydshieh
Copy link
Collaborator

ydshieh commented Oct 18, 2022

@traveler-pinkie sorry for being late here. Are you still interested in working on Marian config files?

@traveler-pinkie
Copy link
Author

@ydshieh . Thanks for commenting back. But I think at the moment I should probably study a little bit more. It looks like I was having more difficulty then I should have. With my skills currently. I think it's best if someone else works on it. Sorry and thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants