Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doctest] - Fixing doctest configuration_pegasus_x.py #19725

Merged
merged 6 commits into from
Oct 18, 2022

Conversation

mukesh663
Copy link
Contributor

What does this PR do?

Fixes #19487
Added (with random weights) in configuration_pegasus_x.py.
Added configuration_pegasus_x.py in documentation_tests.txt.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ydshieh

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 18, 2022

Hi @mukesh663 There seems to be some CI issue. Could you push again with an empty commit?

You can do git commit --allow-empty then push :pray.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mukesh663 mukesh663 closed this Oct 18, 2022
@mukesh663 mukesh663 deleted the fixing_doctest_pegasus_x_config branch October 18, 2022 14:58
@mukesh663 mukesh663 restored the fixing_doctest_pegasus_x_config branch October 18, 2022 14:58
@mukesh663 mukesh663 deleted the fixing_doctest_pegasus_x_config branch October 18, 2022 14:58
@ydshieh
Copy link
Collaborator

ydshieh commented Oct 18, 2022

Hi, @mukesh663 I haven't merge your PR yet ...but you already closed the PR and delete the branch 😢

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 18, 2022

Are you able to restore the branch ?

@mukesh663 mukesh663 restored the fixing_doctest_pegasus_x_config branch October 18, 2022 15:09
@mukesh663
Copy link
Contributor Author

Are you able to restore the branch ?

@ydshieh Sorry for the mishap. I have restored the branch.

@mukesh663 mukesh663 reopened this Oct 18, 2022
@ydshieh ydshieh merged commit f3ed26a into huggingface:main Oct 18, 2022
@ydshieh
Copy link
Collaborator

ydshieh commented Oct 18, 2022

Merged, thank you again!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@mukesh663 mukesh663 deleted the fixing_doctest_pegasus_x_config branch October 19, 2022 01:32
kashif pushed a commit to kashif/transformers that referenced this pull request Oct 21, 2022
)

* Fixed pegasus_x config doctest

* Test commit

Co-authored-by: mukesh663 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔥[Community Event] Doc Tests Sprint - Configuration files🔥
3 participants