Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark test_save_load_fast_init_from_base as is_flaky #20200

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Nov 14, 2022

What does this PR do?

Mark test_save_load_fast_init_from_base as is_flaky.

@HuggingFaceDocBuilder
Copy link

HuggingFaceDocBuilder commented Nov 14, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh force-pushed the mark_test_save_load_fast_init_from_base_flaky branch from b7504c3 to 72e4ccc Compare November 14, 2022 10:48
Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(.

Any ways you found a solution to make the error reproducible ?

I'm really thinking the issue is in the test with the random weight drop, but since I could never get a reproducible way to make it fail it was hard to debug.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Nov 14, 2022

I guess the best first step is to run it 1000 times (in a loop) and see how many times it fails (before and after your PR 20042).

Sometimes it is difficult to get reproducible failure if it is flaky.

@sgugger
Copy link
Collaborator

sgugger commented Nov 14, 2022

As I commented before, this probably comes from models having weights initialized outside of the _init_weights function. A way to debug would be to drop somewhere which weight was randomly dropped when the test has failed (if it's printed for instance, we can look for it in the logs)

@ydshieh ydshieh merged commit 536e60d into main Nov 14, 2022
@ydshieh ydshieh deleted the mark_test_save_load_fast_init_from_base_flaky branch November 14, 2022 17:51
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants