Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
assert
onget_register
assert
are bad, so we remove one here, and give a second chance forget_register
to execute properly if/when register doesn't start with a$
(like PPC or MIPS at least).Description/Motivation/Screenshots
Register names don't always start with
$
(sometimes nothing - MIPS/PPC, something$
- x64, sometimes%
- SPARC).This PR allows
get_register
to still attempt to get the value usingFrame.read_register()
even if the register doesn't start with$
.This PR should fix #752
How Has This Been Tested?
Checklist
dev
branch, notmaster
.