-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyper should skip automatic Content-Length header for HTTP 1xx responses #2215
Comments
psmit
added a commit
to psmit/hyper
that referenced
this issue
Jun 3, 2020
psmit
added a commit
to psmit/hyper
that referenced
this issue
Jun 3, 2020
psmit
added a commit
to psmit/hyper
that referenced
this issue
Jun 3, 2020
seanmonstar
added
A-http1
Area: HTTP/1 specific.
A-server
Area: server.
E-easy
Effort: easy. A task that would be a great starting point for a new contributor.
labels
Jul 29, 2020
psmit
added a commit
to psmit/hyper
that referenced
this issue
Jul 29, 2020
3 tasks
seanmonstar
pushed a commit
that referenced
this issue
Mar 5, 2021
BenxiangGe
pushed a commit
to BenxiangGe/hyper
that referenced
this issue
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similar to issue #1797 hyper should not set a content-length header for a number of different scenario's. Quoting RFC 7230, section 3.3.2 6th paragraph:
At this moment the content-length header is set for 101 Switch Protocols responses. The resulting issue is that e.g. with a warp WebSocket server, a .Net client will drop the connection after 100 seconds: https://stackoverflow.com/a/44553521/85514 .
I believe the solution should be similar to [b342c38], and I'm willing to make a PR to do that. However, I'm not familiar enough with the code base to see if that would fix the problem / has any other implications.
The text was updated successfully, but these errors were encountered: