Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.6 doesn't build on OS X with default-features=false, features = ["security-framework"] #819

Closed
luser opened this issue Jun 6, 2016 · 2 comments
Labels
C-bug Category: bug. Something is wrong. This is bad!

Comments

@luser
Copy link

luser commented Jun 6, 2016

I tried using hyper 0.9.6 with security-framework enabled on OS X, my Cargo.toml snippet looks like:

[dependencies.hyper]
version = "0.9.6"
default-features = false
features = ["security-framework"]

I get this build error:

   Compiling hyper v0.9.6
/Users/luser/.multirust/toolchains/stable/cargo/registry/src/github.com-88ac128001ac3a9a/hyper-0.9.6/src/client/proxy.rs:19:72: 19:86 error: type name `net::Openssl` is undefined or not in scope [E0412]
/Users/luser/.multirust/toolchains/stable/cargo/registry/src/github.com-88ac128001ac3a9a/hyper-0.9.6/src/client/proxy.rs:19 pub fn tunnel(proxy: (Cow<'static, str>, u16)) -> Proxy<HttpConnector, ::net::Openssl> {
                                                                                                                                                                                                   ^~~~~~~~~~~~~~
/Users/luser/.multirust/toolchains/stable/cargo/registry/src/github.com-88ac128001ac3a9a/hyper-0.9.6/src/client/proxy.rs:19:72: 19:86 help: run `rustc --explain E0412` to see a detailed explanation
/Users/luser/.multirust/toolchains/stable/cargo/registry/src/github.com-88ac128001ac3a9a/hyper-0.9.6/src/client/proxy.rs:19:72: 19:86 help: no candidates by the name of `Openssl` found in your project; maybe you misspelled the name or forgot to import an external crate?
error: aborting due to previous error
Could not compile `hyper`.

To learn more, run the command again with --verbose.

If I leave out the features = ["security-framework"] it builds fine. I don't have homebrew OpenSSL installed, so if I leave out the default-features = false it fails trying to build openssl.

@luser
Copy link
Author

luser commented Jun 6, 2016

I get the same error if I checkout the 0.9.x branch from this repo and run cargo build --no-default-features --features=security-framework.

luser added a commit to luser/hyper that referenced this issue Jun 6, 2016
luser added a commit to luser/hyper that referenced this issue Jun 6, 2016
…ity-framework`.

The build on OS X was broken in this configuration.

Fixes hyperium#819
luser added a commit to luser/hyper that referenced this issue Jun 6, 2016
…ity-framework`

The build on OS X was broken in this configuration.

Fixes hyperium#819
luser added a commit to luser/hyper that referenced this issue Jun 6, 2016
…s=security-framework`

The build on OS X was broken in this configuration.

Fixes hyperium#819
luser added a commit to luser/hyper that referenced this issue Jun 6, 2016
…s=security-framework`

The build on OS X was broken in this configuration.

Fixes hyperium#819
@seanmonstar seanmonstar added the C-bug Category: bug. Something is wrong. This is bad! label Jun 9, 2016
@seanmonstar
Copy link
Member

I've publish v0.9.7 to crates.io that includes your fix. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug. Something is wrong. This is bad!
Projects
None yet
Development

No branches or pull requests

2 participants