fix(http1): trim obs-folded headers when unfolding #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
obs-fold-replace-harder
branch
from
bd7183c
to
8286d78
Compare
nox
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to simply replace any
\rand\nwith a space. While that much is valid, it wouldn't replace leading HTABs, which are also used to start a folded line. The specification also says 1-or-more, and curl chooses to make that exactly 1. By trimming while unfolding, we get the same output.@nox did you want to check that while this does change the number of whitespaces that might be in a header field, this hopefully shouldn't break your use cases?