feat: Make boxed function public #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
make-boxed-function-public
branch
2 times, most recently
from
58ca572
to
21c781a
Compare
djc
approved these changes
Jun 26, 2024
examples/src/h2c/server.rs
Outdated
| let svc = self | ||
| .s | ||
| .clone() | ||
| .map_request(|req: Request<Incoming>| req.map(tonic::body::boxed)); |
There was a problem hiding this comment.
Does this really need to specify the type of req?
There was a problem hiding this comment.
The body type seems not to be needed. Fixed it.
tottoto
force-pushed
the
make-boxed-function-public
branch
from
21c781a
to
9ca6e19
Compare
tottoto
force-pushed
the
make-boxed-function-public
branch
from
9ca6e19
to
80e1b19
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing the way to create body gives greater flexibility. This change eliminates the need to use axum's features in the case of h2c example.