feat(build): Add extern_path config support #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for prost-build's "extern_path" feature. This allows you to reference another prost-generated protobuf, including any traits that may have been defined for it, from another crate or location.
LucioFranco
reviewed
Jan 10, 2020
tonic-build/src/lib.rs
Outdated
| /// Declare externally provided Protobuf package or type. | ||
| /// | ||
| /// Passed directly to `prost_build::Config.extern_path`. | ||
| pub fn extern_path<T: AsRef<str>>(mut self, proto_path: T, rust_path: T) -> Self { |
There was a problem hiding this comment.
quick change, can you change both params to be proto_path: impl AsRef<str>
LucioFranco
approved these changes
Jan 10, 2020
LucioFranco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for prost-build's "extern_path" feature. This allows you to
reference another prost-generated protobuf, including any traits that
may have been defined for it, from another crate or location.
Motivation
When using protobuf definitions not only defined in, but also extended by, another crate - you need to use prost's
extern_pathfeature, so that the generated code references your extended external definitions, rather than creating new ones.Solution
Add
extern_pathtotonic-build.There are no tests, as there were none to begin with. It does Work On My Machine, though.