Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transport): Use Uri host if no domain for tls #244

Merged
merged 2 commits into from
Jan 20, 2020
Merged

fix(transport): Use Uri host if no domain for tls #244

merged 2 commits into from
Jan 20, 2020

Conversation

LucioFranco
Copy link
Member

Fixes #239

@LucioFranco LucioFranco mentioned this pull request Jan 18, 2020
Closed
@Nokel81
Copy link

Nokel81 commented Jan 20, 2020

Tested, this PR does seem to work as intended.

@LucioFranco
Copy link
Member Author

@Nokel81 great, thanks for the update, ill get a release of this out shortly.

@LucioFranco LucioFranco merged commit 6de0b4d into master Jan 20, 2020
@LucioFranco LucioFranco deleted the lucio/fix-tls-domain branch January 20, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endpoint.connect() with TLS fails with InvalidDNSNameError
2 participants
@LucioFranco @Nokel81