feat: Add Status with Details Constructor #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where should I add the tests? Wasn't quite sure where to place them as they require a generated proto fixture. |
LucioFranco
requested changes
Mar 29, 2020
tonic/src/status.rs
Outdated
| } | ||
|
|
||
| /// Create a new `Status` with the associated code, message, and protobuf details field. | ||
| pub fn with_details(code: Code, message: impl Into<String>, details: impl Message) -> Status { |
There was a problem hiding this comment.
I actually believe we should not include a prost based one here. I think we can just have the one above that takes a Bytes and we remove the impl Into. We can also rename the one above to with_details. then let the user choose if they want to encode via prost or something else.
There was a problem hiding this comment.
Agreed. Just copy pasta from the PR I inherited. I'm fairly new to Rust so I appreciate your patience. Is this cargo check --no-default-features CI check to enforce that there's no unnecessary coupling of external crates to the core library?
LucioFranco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are just a Copy pasta of this pr in tower-rs.
Motivation
Reference #292 for motivation.
Solution
The prescribed solution exposes two constructors with
Status::with_detailsandStatus::with_raw_detailsthat allow the caller to construct a Status with aCode,String, andBytesor aMessageto be converted into bytes.