Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transport): Add AsRef impl for Certificate #326

Merged
merged 1 commit into from
Apr 9, 2020
Merged

feat(transport): Add AsRef impl for Certificate #326

merged 1 commit into from
Apr 9, 2020

Conversation

IvanVTBTL
Copy link
Contributor

@IvanVTBTL IvanVTBTL commented Apr 7, 2020 •
edited
Loading

Motivation

Currently there is no way to examine certificates obtained by peer_certs functions

Solution

Introduced functions enable consumer to parse and examine provided DER certificates

@IvanVTBTL IvanVTBTL changed the title Adding traits to tonic::transport::Certificate Adding as_ref to tonic::transport::Certificate Apr 7, 2020
@IvanVTBTL
Copy link
Contributor Author

@LucioFranco pinging as suggested on discord

LucioFranco
LucioFranco approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@LucioFranco LucioFranco changed the title Adding as_ref to tonic::transport::Certificate feat(transport): Add AsRef impl for Certificate Apr 9, 2020
@LucioFranco LucioFranco merged commit d2ad8df into hyperium:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanVTBTL @LucioFranco