Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transport) Do not panic when building and Endpoint with an invali… #438

Merged
merged 2 commits into from
Aug 31, 2020
Merged

fix(transport) Do not panic when building and Endpoint with an invali… #438

merged 2 commits into from
Aug 31, 2020

Conversation

alce
Copy link
Collaborator

@alce alce commented Aug 29, 2020

Fixes #437

@alce alce mentioned this pull request Aug 29, 2020
Closed
LucioFranco
LucioFranco approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be advantage to using the from_static call but I am not too concerned for this case since its rare and allocating is also fine.

@LucioFranco
Copy link
Member

This is a breaking change and we will need to release it as so.

@LucioFranco LucioFranco merged commit 26ce9d1 into hyperium:master Aug 31, 2020
@alce alce deleted the dont-panic branch August 31, 2020 15:35
This was referenced Mar 18, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client::connect(uri) panics on invalidly formatted URI (three slashes)
2 participants
@alce @LucioFranco