feat(transport): add user-agent header to client requests. #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a user-agent header to client requests. The default value is
tonic/x.x.x
. The value can be configured through theChannel
builder.The value passed to the
user_agent
method will be prepended to the default, in this case the full value will be:Greeter 1.1 tonic/0.3.1
.The header is added by a new
UserAgent
layer in the client's service stack. While this is not the most straight forward implementation, it seemed to be the cleanest and safest one. It also aligns better with other client implementations (grpc-go clients, in particular).Alternatives
user-agent
from the list of grpc reserved headers.user-agent
header in tonic <-> http request conversions.Endpoint
to theclient::Grpc
struct and set the header after converting the request....and maybe others.
fixes #453