Remove grpc-timeout header from reserved headers #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
approved these changes
Apr 13, 2021
|
Makes sense while we wait for #516 |
|
Thank you :) |
LucioFranco
added a commit
that referenced
this pull request
Apr 13, 2021
This reverts commit 0b53598.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have some gRPC servers in Java which requires callers to it set deadline. Currently seems it is not possible to use tonic as a client to talk to those servers as we cannot set
grpc-timeouton the header?As it also mentioned and others would like to remove this as well in PR #516, also related to this discussion #75.
Not sure when can #516 be shipped in but this change could perhaps go in first as it blocks not me (see #75 (comment))
Solution
Remove
grpc-timeoutfrom the reserved list.Otherwise please let me know how to set
deadlineon the call from tonic as a client.