Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tonic-build: Allow setting skip_protoc_run on the prost Builder #1318

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

pruthvikar
Copy link
Contributor

Motivation

prost-build has a configuration option called skip_protoc_run that prevents running protoc. This option is not exposed in tonic-build. The option can be used to run protoc externally or to use an alternative like protox.

Solution

This PR adds the option to set skip_protoc_run which is passed on to the prost-build configuration.

@LucioFranco
Copy link
Member

#1326 will fix CI for you, so once that is merged should be able to rebase and get green ci

@LucioFranco
Copy link
Member

Its been merged you can reabase and CI should work.

@LucioFranco LucioFranco added this pull request to the merge queue Mar 20, 2023
@LucioFranco LucioFranco merged commit b3358dc into hyperium:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants