Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Don't replace extern_paths #261

Merged
merged 5 commits into from
Feb 18, 2020

Commits on Feb 6, 2020

  1. don't replace extern_path'd paths

    tonic-build will replace all paths except for google well known types
    with one rooted at the super module. For paths that have already been
    replaced with a fully qualified path via the extern_path config option,
    (e.g. "::uuid::Uuid"), this results in an invalid path
    (e.g. "super::::uuid::Uuid"), and a build failure. These paths should
    also be excluded when prefixing relative modules with super.
    danny-osmos committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    2361b24 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. add doc in tonic-build clarifying extern_path

    extern_path expects fully qualified proto and rust paths
    danny-osmos committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    6a16fd5 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. Configuration menu
    Copy the full SHA
    f8892cd View commit details
    Browse the repository at this point in the history
  2. add test cast case for extern path fix

    add a test that extern path does indeed result in service types using
    the specified type from an external crate. we test this by creating a
    service type that has a proto from a different crate, and asserting that
    it does indeed impl a trait from that crate
    danny-osmos committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    936e4a2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7bf65a4 View commit details
    Browse the repository at this point in the history